Extend config check to assert for REPLICA IDENTITY on tables and drop index bug fix #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
shayonj
commented
Jan 21, 2024
shayonj
commented
- config check now performs an additional check to ensure all tables replicating (or about to be) have some form of replica identity setup. This way, if when the subscription starts, it doesn't fail hard if the one of the tables cannot be replicate. This usually involves having a PK, index or FULL REPLICA identity
- Bug fix with drop indices when custom set of tables are passed
- Refactor a bit of tables list is derived
… index bug fix - config check now performs an additional check to ensure all tables replicating (or about to be) have some form of replica identity setup. This way, if when the subscription starts, it doesn't fail hard if the one of the tables cannot be replicate. This usually involves having a PK, index or FULL REPLICA identity - Bug fix with drop indices when custom set of tables are passed - Refactor a bit of tables list is derived
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.